-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI tasks #16
Add CI tasks #16
Conversation
I think this needs the merge of #15 which fixes formatting and clippy warnings. |
Yeah if you based it on #15 then I fixed a bunch clippy stuff + fmt waiting Just a tip that @obycode mentioned that he likes "Conventional Commits" -> https://www.conventionalcommits.org/en/v1.0.0/ |
Yeah, it's helpful to auto-generate changelogs and to determine release versions numbers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @Acaccia!
I went ahead and enabled the check that the be required to pass before PRs can merge into |
I always agree with commit conventions. I sadly did not now we were following one on this repo. This should be in the Readme or a CONTRIBUTING.md file. And in this case, we should also describe the possible types and scopes. |
6a70b31
to
7e37369
Compare
Woohoo, these checks are working great! 🎉 |
This PR adds some CI to the repo:
Closes #12